Trenches are really popular with hobbyists who make military miniatures and battle scenes. To make a good trench or series of trenches you just have to plan ahead so you get it right.
Once you have designed your diorama on paper and know where the trenches will go you can then build the frame and incorporate the trenches right into it. Here is a video that shows you how to do it.